Skip to content

fix: fail supported PHP image builds below the Oct 2026 security release - #255

Merged
AaronFeledy merged 6 commits into
mainfrom
fix/php-cve-2026-10
Nov 16, 2026
Merged

AaronFeledy merged 6 commits into
mainfrom
fix/php-cve-2026-10

Conversation

@AaronFeledy

@AaronFeledy AaronFeledy commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Summary

Supported devwithlando/php images (8.2, 8.3, 8.4, 8.5, apache and fpm) refuse to build unless PHP_VERSION is at least the 22 Oct 2026 security release:

  • 8.5.12
  • 8.4.27
  • 8.3.36
  • 8.2.35

Those floors are CVE-2026-109618 and CVE-2026-109619. The check is a RUN immediately after the final FROM, so a stale base fails the build before build-push-action pushes. pull: true is there so BuildKit resolves the official tag from the registry. Tags stay at -7. No plugin release. EOL PHP runtimes (8.1 and older) are not security-patched by this; legacy apt-source maintenance only restores their existing builds.

Merging to main rebuilds and publishes the production tags. This PR only publishes -edge tags. Do not treat a green EOL job as a fix. After the main build, confirm the eight -7 Hub digests moved and php -v on amd64 and arm64 meets the floor. Users pick the new image up with lando rebuild, not lando start.

Test plan

  • The eight supported jobs fail closed if the base is older than the floor
  • After merge, Hub digests for 8.2/8.3/8.4/8.5 apache and fpm -7 differ from the 2026-06-24 publishes
  • php -v on both platforms meets the floor
  • EOL jobs are not described as patched

Note

Medium Risk
Changes how production multi-arch PHP images are built and published, and enforce minimum PHP versions at build time; mistakes could block releases or ship stale bases.

Overview
Supported PHP 8.2–8.5 FPM/Apache Dockerfiles now fail the build at image time unless PHP_VERSION meets pinned MIN_PHP floors (wired from build-php-images.yml). EOL bullseye images (7.3–8.0) and the 7.3 example gain Debian archive apt mirrors so apt still works without dropping signature checks.

The PHP image workflow stops using QEMU multi-platform builds on one runner: each tag/arch builds on native runners, pushes by digest, and a new merge job publishes the multi-arch Hub tag. PR/unit CI fixes include macos-15-intel, matrix-backed Lando version for PHP tests, and Leia pinned to 0.6.7 for Node 18 runners.

Reviewed by Cursor Bugbot for commit 77b909e. Bugbot is set up for automated code reviews on this repo. Configure here.

CI maintenance

Pinned the Leia action fallback to the existing lockfile version so its Node 18 runner does not install Node 24-only Leia 2. Restored bullseye archive package sources without disabling package signature verification. The PHP integration matrix now actually selects its stable/edge Lando version.

Local validation: lint and docs build passed; unit command passed (0 passing / 1 pending placeholder). Isolated setup/test/cleanup Leia smoke passed under Node 18.20.8. Full integration and multi-platform image validation are pending the new CI runs.

Native amd64 and arm64 runners now build each image independently and publish the multiarch tag only after both platform digests are uploaded. This avoids QEMU-only legacy dpkg crashes without dropping either architecture. The source rewrite now covers both Debian security mirror hostnames; the PHP 7.3 Node-install fixture repairs its inherited security source before apt runs.

8.2-8.5 images now refuse to build unless PHP_VERSION is at least
8.2.35, 8.3.36, 8.4.27, or 8.5.12. Tags stay at -7 so existing installs
pick the patched image up on lando rebuild. EOL images are unchanged.
@netlify

netlify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for lando-php ready!

Name Link
🔨 Latest commit 77b909e
🔍 Latest deploy log https://app.netlify.com/projects/lando-php/deploys/6afb766ebb755bbecbbc2575
😎 Deploy Preview https://deploy-preview-255--lando-php.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 91 (🟢 up 1 from production)
Accessibility: 98 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ebe96f6. Configure here.

Comment thread .github/workflows/build-php-images.yml Resolved
@AaronFeledy
AaronFeledy merged commit ce06035 into main Nov 16, 2026
122 checks passed
@AaronFeledy
AaronFeledy deleted the fix/php-cve-2026-10 branch November 16, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant